[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/30] virtio-pci: replace BusState.allow_hotplu
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 15/30] virtio-pci: replace BusState.allow_hotplug with hotplug_handler |
|
Date: |
Wed, 24 Sep 2014 16:53:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 24/09/2014 16:51, Igor Mammedov ha scritto:
>> > So this is the opposite of icc-bus; here you need to call the simple
>> > hot-unplug callback in the hotplug handler, right?
> It's only to workaround bus_add_child() limitation, there is no need
> to call unplug callback for child of this bus, since bus and child device
> are manually managed by owner of bus without involving hotplug machinery
> (via PCIDeviceClass.[init|exit] callbacks).
>
> Perhaps instead we should just allow to add child to bus is bus_add_child()
> regardless whether it's hotpluggable or not and drop this and other
> similar patches.
Yeah, that would be great and would simply usb-storage as well.
Hotpluggability really refers to adding device after initial bring-up of
the bus. If the controller is hotplugged together with something below,
I don't think that counts.
Paolo
- Re: [Qemu-devel] [PATCH 12/30] qdev: add simple/generic unplug callback for HotplugHandler, (continued)
[Qemu-devel] [PATCH 15/30] virtio-pci: replace BusState.allow_hotplug with hotplug_handler, Igor Mammedov, 2014/09/24
[Qemu-devel] [PATCH 17/30] virtio-mmio: drop useless bus->allow_hotplug = 0, Igor Mammedov, 2014/09/24
[Qemu-devel] [PATCH 18/30] s390x: drop not used allow_hotplug in event-facility, Igor Mammedov, 2014/09/24
[Qemu-devel] [PATCH 19/30] s390x: convert s390-virtio to hotplug handler API, Igor Mammedov, 2014/09/24
[Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw to hotplug handler API, Igor Mammedov, 2014/09/24