[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/2] trace: [qmp] Add commands to query and c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/2] trace: [qmp] Add commands to query and control event tracing state |
Date: |
Wed, 24 Sep 2014 08:45:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 08/25/2014 05:19 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> qapi-schema.json | 3 ++
> qapi/trace.json | 65 ++++++++++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 35 ++++++++++++++++++++++++
> trace/Makefile.objs | 1 +
> trace/qmp.c | 75
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 179 insertions(+)
> create mode 100644 qapi/trace.json
> create mode 100644 trace/qmp.c
> +##
> +# @trace-event-set-state:
> +#
> +# Set the dynamic tracing state of events.
> +#
> +# @name: Event name pattern (case-sensitive glob).
> +# @enable: Whether to enable tracing.
> +# @ignore-unavailable: #optional Do not match unavailable events with @name.
Would be nice to state that this bool defaults to false (at least,
that's my assumption).
> +
> +Query the state of events.
> +
> +Example:
> +
> +-> { "execute": "trace-event-get-state", "arguments": { "name":
> "qemu_memalign" } }
> +<- { "return": [ { "name": "qemu_memalign", "state": "disabled" } ] }
It would be nice to use a glob in the "name" of the example, and show a
multi-element array as the result.
Those changes can be done in a followup patch, since Stefan has already
queued this patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 1/2] trace: [qmp] Add commands to query and control event tracing state,
Eric Blake <=