[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler AP
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API |
Date: |
Wed, 24 Sep 2014 15:01:44 +0200 |
On Wed, 24 Sep 2014 11:47:49 +0000
Igor Mammedov <address@hidden> wrote:
> Series unifies different hotplug mechanisms to a recent
> hotplug-handler API and does shallow conversion of
> devices that still use legacy qdev hotplug to it dropping
> not used after that legacy hotplug path [29/30].
> It also relaces SCSI's own way to do hotplug/unplug with
> hotplug-handler callbacks leaving it the only method
> perform hotplug tasks.
> And the last patch [30/30] allows to unplug of BUS-less
> devices using hotplug-handler API.
>
> Converted devices are covered with new hotplug
> unit-tests, except of:
> s390x-*: I have no idea how or means to test it, but code
> is close to virtio, so it's converted using
> virtio template
> pvscsi: is broken, so no means to test it
>
> Git tree for testing:
> https://github.com/imammedo/qemu/commits/hp_ctrl_conversion_v1
Gave it a quick test with the s390-ccw-virtio machine.
device_add virtio-balloon-ccw,id=xxx,devno=fe.2.1111
works (device added in qemu and crws injected to guest). However,
device_del xxx
removes the device in qemu but no crws are injected to the guest. That
seems to indicate that virtio_ccw_busdev_unplug() isn't called?
<runs under gdb>
Indeed, the callback isn't invoked for hotunplug.
- Re: [Qemu-devel] [PATCH 03/30] test: virtio-rng: check if hot-plug/unplug works, (continued)