Re: [Qemu-devel] [Qemu-trivial] [PATCH] disas/arm: Remove redefinition of ATTRIBUTE_UNUSED

[Tobias Klauser]

On 2014-09-24 at 09:58:45 +0200, Michael Tokarev <address@hidden> wrote:
> 18.09.2014 21:25, Tobias Klauser wrote:
> > ATTRIBUTE_UNUSED is already defined in disas/bfd.h, which is included.
> > Thus, there is no need to redefine it.
> 
> Is there any harm in keeping it here?

No.

> While it really is a redifinition, I'm not sure what's the right thing
> here.  This whole code is not from qemu, it is an external source imported,
> and that source is being maintained (but under different license as has
> already been discussed, so keeping changes at minimum might not be that
> good idea anymore).  On the other hand this symbol is so common it should
> be defined in a common header.  Yet on another hand, for these external
> sources wich has public API, it might not be a good idea to define it in
> a header to start with, because it might clash with project-local define,
> so it might be better to define it in either private header or in individual
> source.

Ah, I didn't know it was non-qemu code (but now that I look at it again,
I probably should have realized that sooner ;). Thanks for the
explanation.

> Oh well, so much for so trivial thing... ;)

:) Sorry, it wasn't my intention to cause much discussion, trouble or
work for maintainers with that patch. I don't feel strongly about, I
just stumbled across it when browsing the source and found it odd to see
a macro defined just below the #include of a header which defines the
same macro.

Please just ignore the patch then :)

Thanks
Tobias