Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.

[Gonglei (Arei)]

> Subject: Re: [PATCH 5/7] qdev: set the object property's description to the 
> qdev
> property's.
> 
> Il 23/09/2014 15:08, address@hidden ha scritto:
> > From: Gonglei <address@hidden>
> >
> > When we call qdev_alias_all_properties() adding alias properties to
> > the source object all qdev properties on the target DeviceState,
> > set the object property's description to the qdev property's.
> >
> > c: Paolo Bonzini <address@hidden>
> > Cc: Michael S. Tsirkin <address@hidden>
> > Cc: Markus Armbruster <address@hidden>
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> >  hw/core/qdev.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> > index fcb1638..61d352c 100644
> > --- a/hw/core/qdev.c
> > +++ b/hw/core/qdev.c
> > @@ -796,6 +796,9 @@ void qdev_alias_all_properties(DeviceState *target,
> Object *source)
> >              object_property_add_alias(source, prop->name,
> >                                        OBJECT(target),
> prop->name,
> >                                        &error_abort);
> > +            object_property_set_description(source, prop->name,
> > +
> prop->info->description,
> > +                                            &error_abort);
> 
> Please do this directly in object_property_add_alias.
> 
OK. 

This way I have to add a description string parametet to
object_property_add_alias function. Will do in the next version. :)

Best regards,
-Gonglei

> Paolo
> 
> >          }
> >          class = object_class_get_parent(class);
> >      } while (class != object_class_by_name(TYPE_DEVICE));
> >