Re: [Qemu-devel] [PATCH] pci-hotplug-old: avoid lossing error message

[Gonglei (Arei)]

> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: Thursday, September 18, 2014 8:22 PM
> To: Gonglei (Arei); address@hidden
> Cc: Huangweidong (C); address@hidden; address@hidden
> Subject: Re: [Qemu-devel] [PATCH] pci-hotplug-old: avoid lossing error message
> 
> On 09/18/2014 02:53 AM, address@hidden wrote:
> > From: Gonglei <address@hidden>
> 
> s/lossing/losing/ in the subject.
> 
> >
> > When scsi_bus_legacy_add_drive() produce error,
> 
> s/produce error/produces an error/
> 
> > we will loss error message. Using error_report
> 
> s/loss/lose the/
> s/Using error_report/Use error_report to/
> 
> > report it.
> >
> > Cc: Markus Armbruster <address@hidden>
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> >  hw/pci/pci-hotplug-old.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> 
> With the commit message improved,
> Reviewed-by: Eric Blake <address@hidden>
> 

Thanks, Eric.

I posted v2 and Markus have reviewed. 
If you haven't dissidence for v2, I will post v3 by your comments 
and add your both 'R-b' tag. :)

Best regards,
-Gonglei

> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org