[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/19] dev-uas: convert init to realize
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 09/19] dev-uas: convert init to realize |
Date: |
Thu, 18 Sep 2014 12:13:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 18/09/2014 11:32, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> hw/usb/dev-uas.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
> index 9832385..884c003 100644
> --- a/hw/usb/dev-uas.c
> +++ b/hw/usb/dev-uas.c
> @@ -892,7 +892,7 @@ static void usb_uas_handle_destroy(USBDevice *dev)
> qemu_bh_delete(uas->status_bh);
> }
>
> -static int usb_uas_init(USBDevice *dev)
> +static void usb_uas_realize(USBDevice *dev, Error **errp)
> {
> UASDevice *uas = DO_UPCAST(UASDevice, dev, dev);
>
> @@ -905,8 +905,6 @@ static int usb_uas_init(USBDevice *dev)
>
> scsi_bus_new(&uas->bus, sizeof(uas->bus), DEVICE(dev),
> &usb_uas_scsi_info, NULL);
> -
> - return 0;
> }
>
> static const VMStateDescription vmstate_usb_uas = {
> @@ -928,7 +926,7 @@ static void usb_uas_class_initfn(ObjectClass *klass, void
> *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
> USBDeviceClass *uc = USB_DEVICE_CLASS(klass);
>
> - uc->init = usb_uas_init;
> + uc->realize = usb_uas_realize;
> uc->product_desc = desc_strings[STR_PRODUCT];
> uc->usb_desc = &desc;
> uc->cancel_packet = usb_uas_cancel_io;
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH 13/19] usb-ccid: convert init to realize, (continued)
- [Qemu-devel] [PATCH 13/19] usb-ccid: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 14/19] dev-hid: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 16/19] usb-audio: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 15/19] dev-wacom: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 09/19] dev-uas: convert init to realize, arei.gonglei, 2014/09/18
- Re: [Qemu-devel] [PATCH 09/19] dev-uas: convert init to realize,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 05/19] libusb: using error_report instead of fprintf, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 11/19] dev-bluetooth: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 17/19] usb-redir: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 07/19] dev-storage: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH 03/19] usb-net: convert init to realize, arei.gonglei, 2014/09/18