[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unl
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed |
Date: |
Thu, 18 Sep 2014 13:26:46 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
On 09/18/2014 01:07 AM, Stefan Hajnoczi wrote:
> On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy <address@hidden> wrote:
>> On 09/17/2014 07:25 PM, Paolo Bonzini wrote:
>> btw any better idea of a hack to try? Testers are pushing me - they want to
>> upgrade the broken setup and I am blocking them :) Thanks!
>
> Paolo's qemu_co_mutex_lock(&s->lock) idea in qcow2_invalidate_cache()
> is good. Have you tried that patch?
Yes, did not help.
>
> I haven't checked the qcow2 code whether that works properly across
> bdrv_close() (is the lock freed?) but in principle that's how you
> protect against concurrent I/O.
I thought we have to avoid qemu_coroutine_yield() in this particular case.
I fail to see how the locks may help if we still do yeild. But the whole
thing is already way behind of my understanding :) For example - how many
BlockDriverState things are layered here? NBD -> QCOW2 -> RAW?
--
Alexey
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, (continued)
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Alexey Kardashevskiy, 2014/09/17
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Alexey Kardashevskiy, 2014/09/16
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Stefan Hajnoczi, 2014/09/17
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Paolo Bonzini, 2014/09/17
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Alexey Kardashevskiy, 2014/09/17
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Stefan Hajnoczi, 2014/09/17
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed,
Alexey Kardashevskiy <=
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Paolo Bonzini, 2014/09/18
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Alexey Kardashevskiy, 2014/09/19
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Stefan Hajnoczi, 2014/09/17
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Eric Blake, 2014/09/17
- Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed, Paolo Bonzini, 2014/09/17