Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

[Gonglei (Arei)]

> From: Markus Armbruster [mailto:address@hidden
> Sent: Tuesday, September 16, 2014 10:26 PM
> To: Paolo Bonzini
> Cc: Gonglei (Arei); address@hidden; Huangweidong (C);
> address@hidden
> Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report
> 
> Paolo Bonzini <address@hidden> writes:
> 
> > Il 16/09/2014 15:54, Gonglei (Arei) ha scritto:
> >>> -----Original Message-----
> >>> From: Gonglei (Arei)
> >>> Sent: Friday, September 12, 2014 3:31 PM
> >>> To: address@hidden
> >>> Cc: address@hidden; Huangweidong (C); address@hidden; Gonglei
> >>> (Arei)
> >>> Subject: [PATCH v2 0/2] usb: Don't use qerror_report
> >>>
> >>> From: Gonglei <address@hidden>
> >>>
> >>> qerror_report() is a transitional interface to help with converting
> >>> existing HMP commands to QMP. It should not be used elsewhere.
> >>>
> >>> v2 -> v1:
> >>>  - update including head files, remove qerror.h and monitor.h,
> >>>    add error-report.h (Markus)
> >>>  - add 'Reviewed-by' tag.
> >>>
> >>> Gonglei (2):
> >>>   redirect.c: Don't use qerror_report()
> >>>   dev-network: Don't use qerror_report_err()
> >>>
> >>>  hw/usb/dev-network.c | 4 ++--
> >>>  hw/usb/redirect.c    | 8 ++++----
> >>>  2 files changed, 6 insertions(+), 6 deletions(-)
> >>>
> >>> --
> >>> 1.7.12.4
> >>>
> >> Hi, Gerd
> >> Would you like to apply this patch series at present? Thanks!
> >
> > I'm not sure what the improvement is?
> 
> The improvement is obvious: three calls of qerror_report() gone.
> 
> The regression isn't as obvious (I missed it, but fortunately Paolo
> spotted it): when we run in QMP context, we screw up the error reply.
> 
> Therefore, we can't take these patches.  We really have to convert to
> realize to get rid of qerror_report() here.

OK, understand it. Thank you, guys :)

Best regards,
-Gonglei