[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/23] block: Eliminate bdrv_iterate(), use b
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/23] block: Eliminate bdrv_iterate(), use bdrv_next() |
Date: |
Tue, 16 Sep 2014 13:04:13 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> @@ -4717,10 +4699,14 @@ static void monitor_find_completion_by_table(Monitor
> *mon,
> break;
> case 'B':
> /* block device name completion */
> - mbs.mon = mon;
> - mbs.input = str;
> readline_set_completion_index(mon->rs, strlen(str));
> - bdrv_iterate(block_completion_it, &mbs);
> + for (bs = bdrv_next(NULL); bs; bs = bdrv_next(bs)) {
> + name = bdrv_get_device_name(bs);
> + if (str[0] == '\0' ||
> + !strncmp(name, str, strlen(str))) {
> + readline_add_completion(mon->rs, name);
> + }
> + }
> break;
> case 's':
> case 'S':
> --
> 1.9.3
>
Reviewed-by: Benoît Canet <address@hidden>
- [Qemu-devel] [PATCH v2 01/23] block: Split bdrv_new_root() off bdrv_new(), (continued)
- [Qemu-devel] [PATCH v2 01/23] block: Split bdrv_new_root() off bdrv_new(), Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo(), Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 07/23] block: Eliminate bdrv_iterate(), use bdrv_next(), Markus Armbruster, 2014/09/13
- Re: [Qemu-devel] [PATCH v2 07/23] block: Eliminate bdrv_iterate(), use bdrv_next(),
Benoît Canet <=
- [Qemu-devel] [PATCH v2 05/23] block: Code motion to get rid of stubs/blockdev.c, Markus Armbruster, 2014/09/13
- Re: [Qemu-devel] [PATCH v2 05/23] block: Code motion to get rid of stubs/blockdev.c, Benoît Canet, 2014/09/16
- [Qemu-devel] [PATCH v2 16/23] pc87312: Drop unused members of PC87312State, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 15/23] ide: Complete conversion from BlockDriverState to BlockBackend, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 17/23] blockdev: Drop superfluous DriveInfo member id, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 21/23] blockdev: Convert qmp_eject(), qmp_change_blockdev() to BlockBackend, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 20/23] block/qapi: Convert qmp_query_block() to BlockBackend, Markus Armbruster, 2014/09/13