[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 0/2] Fix dump_error to return error message
From: |
zhanghailiang |
Subject: |
[Qemu-devel] [PATCH v5 0/2] Fix dump_error to return error message |
Date: |
Tue, 16 Sep 2014 15:30:57 +0800 |
Hi,
In original code, Function dump_error ignores its second parameter which
contains
error reason, it is better to return the error message to the caller.
Here we use error_setg to return the error info to caller.
And at the same time, we turn functions like write_elf64_note() to void,
Because functions shouldn't return an error code _and_ an Error object.
After this modification the code will be more clean.
V4 -> V5:
- Turn functions like write_elf64_note() to void (advised by Luiz Capitulino)
V3 -> V4:
- Adjust the errp argument to the end
- Remove trailing '.' in error messages
V2 -> V3:
- Drop the '\n' in the message when call dump_error(comment of Eric Blake)
V1 -> V2:
- Return the error reason to the caller which suggested by Luiz Capitulino.
zhanghailiang (2):
dump: let dump_error return error info to caller
dump: Don't return error code when return an Error object
dump.c | 333 +++++++++++++++++++++++++++--------------------------------------
1 file changed, 138 insertions(+), 195 deletions(-)
--
1.7.12.4
- [Qemu-devel] [PATCH v5 0/2] Fix dump_error to return error message,
zhanghailiang <=