[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of dupli
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties |
Date: |
Mon, 15 Sep 2014 09:06:12 +0000 |
> > > >
> > > > Sorry, I don't understand your meaning. :(
> > >
> > > I applied your patch, and looked at the property types.
> > >
> > Could you tell me your method looked at properties type?
>
> You can use an HMP command, or you can use
> -device virtio-net-pci,?
OK. Good method.
> changes must not modify output except for adding
> new commands, or fixing bugs (with care).
>
OK.
> > > They should be netdev/vlan/macaddr.
> > > Your patch makes them str/int32/str
> > >
> > Does those changes have any side-effects? Thanks!
>
> Yes. If the types are just "int" and "str" then you
> have no way to know they should have a specific format,
> such as a name of a netdev, valid mac address, or a vlan.
> In fact, vlan=int is a bug since vlan names aren't numbers.
>
Got it.
> > The similar changes for virtio-blk had applied in qemu master.
> >
> > Best regards,
> > -Gonglei
>
> Which commit? Did output change? If yes it's a bug.
No, I checked it again, virtio-blk-pci's properties are 'int' type as
the same as virtio-blk device, so it will have no problem on this point.
I will rework this patch series. Thanks a lot for review! :)
Best regards,
-Gonglei
- [Qemu-devel] [PATCH v2 2/9] virtio: fix virtio-net child refcount in transports, (continued)
- [Qemu-devel] [PATCH v2 2/9] virtio: fix virtio-net child refcount in transports, arei.gonglei, 2014/09/09
- [Qemu-devel] [PATCH v2 3/9] virtio/vhost scsi: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/09
- [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/09
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Gonglei (Arei), 2014/09/14
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Michael S. Tsirkin, 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Gonglei (Arei), 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Michael S. Tsirkin, 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Gonglei (Arei), 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Michael S. Tsirkin, 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties,
Gonglei (Arei) <=
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Gonglei (Arei), 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Gonglei (Arei), 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Michael S. Tsirkin, 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Gonglei (Arei), 2014/09/15
- Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties, Michael S. Tsirkin, 2014/09/15
[Qemu-devel] [PATCH v2 5/9] virtio-serial: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/09
[Qemu-devel] [PATCH v2 6/9] virtio-serial: fix virtio-serial child refcount in transports, arei.gonglei, 2014/09/09
[Qemu-devel] [PATCH v2 7/9] virtio-rng: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/09
Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports, Gonglei (Arei), 2014/09/12
Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports, Gonglei (Arei), 2014/09/19