[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tcg-aarch64: Use 32-bit loads for qemu_ld_i
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] tcg-aarch64: Use 32-bit loads for qemu_ld_i32 |
|
Date: |
Fri, 12 Sep 2014 08:49:23 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/12/2014 07:14 AM, Claudio Fontana wrote:
>> > +++ b/tcg/tcg.h
>> > @@ -194,7 +194,6 @@ typedef struct TCGPool {
>> > typedef enum TCGType {
>> > TCG_TYPE_I32,
>> > TCG_TYPE_I64,
>> > - TCG_TYPE_COUNT, /* number of different types */
>> >
>> > /* An alias for the size of the host register. */
>> > #if TCG_TARGET_REG_BITS == 32
>> > @@ -218,6 +217,8 @@ typedef enum TCGType {
>> > #endif
>> > } TCGType;
>> >
>> > +#define TCG_TYPE_COUNT 2
>> > +
> why this move from the enum to this standalone define?
>
Becuase having the 2 in the enum makes the compiler think we need 2 bits to
store the enum instead of one. I should probably have pulled that out.
r~