[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump
From: |
Nikunj A Dadhania |
Subject: |
Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump |
Date: |
Fri, 12 Sep 2014 16:00:12 +0530 |
User-agent: |
Notmuch/0.17+27~gae47d61 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-redhat-linux-gnu) |
Alex Williamson <address@hidden> writes:
> On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote:
>> The PCI MMIO might be disabled or the device in the reset state.
>> Make sure we do not dump these memory regions.
>>
>> Signed-off-by: Nikunj A Dadhania <address@hidden>
>> ---
>
> If you don't want to dump a memory region then add the ability to set a
> no-dump flag on the region and have vfio call it, don't make something
> as specific as a vfio mmap region. Thanks,
Sure, do you want me to separate it to two patches:
1) Adding skip_dump flag and accessors
2) VFIO using the accessors?
Regards,
Nikunj