[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() o
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path |
|
Date: |
Thu, 11 Sep 2014 07:03:55 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 09/11/2014 06:49 AM, Stefan Hajnoczi wrote:
> Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use
> with operation blocker") broke the error path because it consumed
> local_err instead of propagating it.
>
> The caller has no way to know that the function failed. This caused
> virtio-blk to start "successfully" even though there was a fatal
> dataplane error.
>
> ---
> hw/block/dataplane/virtio-blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature