Re: [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI

[Paolo Bonzini]

Il 02/09/2014 12:24, Peter Maydell ha scritto:
> This patchset converts the two remaining legacy chardevs
> ('socket' and 'udp') to use the new-style parse/kind
> mechanisms, and removes all the no-longer-required
> legacy machinery.
> 
> Patch 1 was posted to the list back in June
> (https://patches.linaro.org/32298/). I've fixed the obvious
> bug picked up in code review, and as far as I can tell from
> the thread we decided that the blocking/non-blocking
> difference between QAPI and legacy wasn't a problem.
> 
> Patch 2 fixes a hole in the functionality of QAPI-described
> UDP chardevs, to avoid regressing the commandline functionality
> when we convert the UDP backend in patch 3.
> 
> Patch 4 may be easier to review as an ignore-whitespaces
> diff (the de-indentation makes the diff a bit awkward).
> 
> Changes v1->v2:
>  * fixed the has_* values as suggested by Markus
>  * added patch 5 which renames the _qapi() function now
>    the legacy version has gone (again, as suggested by
>    Markus)
> 
> Peter Maydell (5):
>   qemu-char: Convert socket backend to QAPI
>   util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram()
>   qemu-char: Convert udp backend to QAPI
>   qemu-char: Remove register_char_driver() machinery
>   qemu-char: Rename register_char_driver_qapi() to
>     register_char_driver()
> 
>  backends/baum.c       |   2 +-
>  backends/msmouse.c    |   2 +-
>  backends/testdev.c    |   2 +-
>  include/sysemu/char.h |   3 +-
>  qemu-char.c           | 353 
> ++++++++++++++++++++++++--------------------------
>  spice-qemu-char.c     |   8 +-
>  ui/console.c          |   3 +-
>  util/qemu-sockets.c   |   3 +-
>  8 files changed, 180 insertions(+), 196 deletions(-)
> 

Hi Peter, are you going to apply these directly?

Paolo