[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 23/26] vmdk: fix vmdk_parse_extents() extent_file lea
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 23/26] vmdk: fix vmdk_parse_extents() extent_file leaks |
Date: |
Fri, 5 Sep 2014 17:13:51 +0100 |
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
block/vmdk.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index 07cb62c..9bf28f3 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -834,6 +834,7 @@ static int vmdk_parse_extents(const char *desc,
BlockDriverState *bs,
ret = vmdk_add_extent(bs, extent_file, true, sectors,
0, 0, 0, 0, 0, &extent, errp);
if (ret < 0) {
+ bdrv_unref(extent_file);
return ret;
}
extent->flat_start_offset = flat_offset << 9;
@@ -853,6 +854,7 @@ static int vmdk_parse_extents(const char *desc,
BlockDriverState *bs,
extent = &s->extents[s->num_extents - 1];
} else {
error_setg(errp, "Unsupported extent type '%s'", type);
+ bdrv_unref(extent_file);
return -ENOTSUP;
}
extent->type = g_strdup(type);
--
1.9.3
- [Qemu-devel] [PULL 12/26] libqos: Added EVENT_IDX support, (continued)
- [Qemu-devel] [PULL 12/26] libqos: Added EVENT_IDX support, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 13/26] qemu-img: clarify src_cache option documentation, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 14/26] qemu-img: fix rebase src_cache option documentation, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 15/26] block/archipelago: Use QEMU atomic builtins, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 16/26] rename parse_enum_option to qapi_enum_parse and make it public, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 19/26] MAINTAINERS: update sheepdog maintainer, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 17/26] qemu-nbd: add option to set detect-zeroes mode, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 18/26] qemu-nbd: fix indentation and coding style, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 20/26] libqos: add a simple first-fit memory allocator, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 22/26] ide: Add wwn support to IDE-ATAPI drive, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 23/26] vmdk: fix vmdk_parse_extents() extent_file leaks,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 24/26] vmdk: fix buf leak in vmdk_parse_extents(), Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 25/26] IDE: Fill the IDENTIFY request consistently, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 26/26] ide: Add resize callback to ide/core, Stefan Hajnoczi, 2014/09/05
- [Qemu-devel] [PULL 21/26] qtest/ide: Uninitialize PC allocator, Stefan Hajnoczi, 2014/09/05
- Re: [Qemu-devel] [PULL 00/26] Block patches, Peter Maydell, 2014/09/05