[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 12/16] pci: avoid losing config updates to MSI/MSI
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v2 12/16] pci: avoid losing config updates to MSI/MSIX cap regs |
Date: |
Wed, 3 Sep 2014 16:45:32 +0300 |
From: Knut Omang <address@hidden>
Since
commit 95d658002401e2e47a5404298ebe9508846e8a39
msi: Invoke msi/msix_write_config from PCI core
msix config writes are lost, the value written is always 0.
Fix pci_default_write_config to avoid this.
Cc: address@hidden
Signed-off-by: Knut Omang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/pci/pci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index daeaeac..d1e9a2a 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1146,9 +1146,10 @@ uint32_t pci_default_read_config(PCIDevice *d,
return le32_to_cpu(val);
}
-void pci_default_write_config(PCIDevice *d, uint32_t addr, uint32_t val, int l)
+void pci_default_write_config(PCIDevice *d, uint32_t addr, uint32_t val_in,
int l)
{
int i, was_irq_disabled = pci_irq_disabled(d);
+ uint32_t val = val_in;
for (i = 0; i < l; val >>= 8, ++i) {
uint8_t wmask = d->wmask[addr + i];
@@ -1170,8 +1171,8 @@ void pci_default_write_config(PCIDevice *d, uint32_t
addr, uint32_t val, int l)
& PCI_COMMAND_MASTER);
}
- msi_write_config(d, addr, val, l);
- msix_write_config(d, addr, val, l);
+ msi_write_config(d, addr, val_in, l);
+ msix_write_config(d, addr, val_in, l);
}
/***********************************************************/
--
MST
- [Qemu-devel] [PULL v2 00/16] pci, pc fixes, features, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 02/16] intel-iommu: introduce Intel IOMMU (VT-d) emulation, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 03/16] intel-iommu: add DMAR table to ACPI tables, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 01/16] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 06/16] intel-iommu: add supports for queued invalidation interface, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 04/16] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "iommu" as a switch, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 07/16] intel-iommu: add context-cache to cache context-entry, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 05/16] intel-iommu: fix coding style issues around in q35.c and machine.c, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 09/16] vhost_net: cleanup start/stop condition, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 08/16] intel-iommu: add IOTLB using hash table, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 12/16] pci: avoid losing config updates to MSI/MSIX cap regs,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v2 10/16] ioh3420: remove unused ioh3420_init() declaration, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 14/16] vhost_net: init acked_features to backend_features, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 15/16] vhost-scsi: init backend features earlier, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 16/16] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit for FADT flags, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 11/16] virtio-net: don't run bh on vm stopped, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 13/16] vhost_net: start/stop guest notifiers properly, Michael S. Tsirkin, 2014/09/03