[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/5] Netduino_USART: Add the Netduino Plus 2
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/5] Netduino_USART: Add the Netduino Plus 2 USART Controller |
Date: |
Mon, 1 Sep 2014 17:30:40 +0100 |
On 24 August 2014 03:09, Peter Crosthwaite <address@hidden> wrote:
> If you make your registers an array, you can index the with the offset
> and remove the repeated s->foo return logic. You can also use a single
> memset to do all the 0 resets.
Hmm. I dislike that style personally, especially for devices
like this which only have a handful of registers.
-- PMM
- Re: [Qemu-devel] [PATCH v1 1/5] Netduino_USART: Add the Netduino Plus 2 USART Controller,
Peter Maydell <=