[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "xhci: Fix number of streams allocated w
|
From: |
Hans de Goede |
|
Subject: |
Re: [Qemu-devel] [PATCH] Revert "xhci: Fix number of streams allocated when using streams" |
|
Date: |
Fri, 29 Aug 2014 14:45:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Hi,
On 08/29/2014 12:45 PM, Gerd Hoffmann wrote:
> This reverts commit d063c3112c4cd23a479ee18720c2bd119da2d315.
>
> "2 << x" is the same as "2 ^ (x + 1)", so the old code is correct.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/usb/hcd-xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 2c5c6f3..c63cadc 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -1151,7 +1151,7 @@ static void xhci_reset_streams(XHCIEPContext *epctx)
> static void xhci_alloc_streams(XHCIEPContext *epctx, dma_addr_t base)
> {
> assert(epctx->pstreams == NULL);
> - epctx->nr_pstreams = 2 << (epctx->max_pstreams + 1);
> + epctx->nr_pstreams = 2 << epctx->max_pstreams;
> epctx->pstreams = xhci_alloc_stream_contexts(epctx->nr_pstreams, base);
> }
>
>
Right, my bad.
Acked-by: Hans de Goede <address@hidden>
Regards,
Hans