Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

[Richard W.M. Jones]

On Fri, Aug 29, 2014 at 04:33:12PM +0800, Hu Tao wrote:
> +    if (prealloc == PREALLOC_MODE_FULL) {
> +        /* posix_fallocate() doesn't set errno. */
> +        result = -posix_fallocate(fd, 0, total_size);
> +        if (result != 0) {

Is it better to test:

  result != ENOSYS && result != EOPNOTSUPP

here?

I think this is definitely the right approach.

Rich.


-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v