qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declarati


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration
Date: Mon, 25 Aug 2014 11:48:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

<address@hidden> writes:

> From: Gonglei <address@hidden>
>
> Signed-off-by: Gonglei <address@hidden>
> ---
>  hw/pci-bridge/ioh3420.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h
> index 7776e5b..ea423cb 100644
> --- a/hw/pci-bridge/ioh3420.h
> +++ b/hw/pci-bridge/ioh3420.h
> @@ -3,8 +3,4 @@
>  
>  #include "hw/pci/pcie_port.h"
>  
> -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction,
> -                       const char *bus_name, pci_map_irq_fn map_irq,
> -                       uint8_t port, uint8_t chassis, uint16_t slot);
> -
>  #endif /* QEMU_IOH3420_H */

Breaks the build

    qemu/hw/pci-bridge/ioh3420.c:159:11: warning: no previous prototype for 
‘ioh3420_init’ [-Wmissing-prototypes]

because it removes the prototype of an unused function.  Keep both for
future use, or remove both.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]