Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding

[Gonglei (Arei)]

> From: Michael S. Tsirkin [mailto:address@hidden
> Subject: Re: [PATCH v2 4/4] ioh3420: Enable ARI forwarding
> 
> On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote:
> > Signed-off-by: Knut Omang <address@hidden>
> 
> BTW pcie_cap_is_arifwd_enabled is still unused.

Not yet, but I have posted a patch series:

[PATCH v2 0/2] add check for PCIe root ports and downstream ports

Which we used this function to check ARI Forwarding is enabled or not.
I hope you can help me review it, thanks a lot!

BTW, I will rebase my patches on Kunt's patch series. And will do some fixes 
about Hu Tao's and Marcel Apfelbaum's comments.

> We really should use it to make ARI work properly, right?
> 
Yes. I think we should.

Best regards,
-Gonglei

> > ---
> >  hw/pci-bridge/ioh3420.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
> > index e6674a1..cce2fdd 100644
> > --- a/hw/pci-bridge/ioh3420.c
> > +++ b/hw/pci-bridge/ioh3420.c
> > @@ -85,6 +85,7 @@ static void ioh3420_reset(DeviceState *qdev)
> >      pcie_cap_root_reset(d);
> >      pcie_cap_deverr_reset(d);
> >      pcie_cap_slot_reset(d);
> > +    pcie_cap_arifwd_reset(d);
> >      pcie_aer_root_reset(d);
> >      pci_bridge_reset(qdev);
> >      pci_bridge_disable_base_limit(d);
> > @@ -119,6 +120,7 @@ static int ioh3420_initfn(PCIDevice *d)
> >          goto err_msi;
> >      }
> >
> > +    pcie_cap_arifwd_init(d);
> >      pcie_cap_deverr_init(d);
> >      pcie_cap_slot_init(d, s->slot);
> >      pcie_chassis_create(s->chassis);
> > --
> > 1.9.0