Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

[Hu Tao]

On Fri, Aug 22, 2014 at 12:54:29PM +0200, Kevin Wolf wrote:
> Am 28.07.2014 um 10:48 hat Hu Tao geschrieben:
> > ping...
> > 
> > All the 6 patches have reviewed-by now.
> 
> Looks mostly good to me, I have only a few minor comments that wouldn't
> block inclusion but could be addressed in follow-up patches.
> 
> However, you have a dependency on a patch series from Max (you use
> minimal_blob_size()), which hasn't been reviewed and merged yet, so your
> series is blocked on that.
> 
> If you want to get your series merged quicker, you could replace this
> with a rough estimate that excludes the clusters used by refcount table
> and blocks. If full preallocation isn't really full, but only
> preallocation of 99.9%, that's probably good enough in practice.

How about my calculation in v10?
https://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg02844.html

It doesn't depend on minimal_blob_size(). In most cases the calculated
size is the same as the size before this patch. I have no test results
on hand, but if you need I can do it.

Regards,
Hu