Re: [Qemu-devel] [PATCH v3 01/10] qcow2: Fix leaks in dirty images

[Benoît Canet]

On Fri, Aug 22, 2014 at 06:31:35PM +0200, Max Reitz wrote:
> When opening dirty images, qcow2's repair function should not only
> repair errors but leaks as well.
> 
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  block/qcow2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/qcow2.c b/block/qcow2.c
> index f9e045f..67d6368 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -898,7 +898,7 @@ static int qcow2_open(BlockDriverState *bs, QDict 
> *options, int flags,
>          (s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) {
>          BdrvCheckResult result = {0};
>  
> -        ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS);
> +        ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LEAKS);
>          if (ret < 0) {
>              error_setg_errno(errp, -ret, "Could not repair dirty image");
>              goto fail;
> -- 
> 2.0.4
> 
Reviewed-by: Benoît Canet <address@hidden>