qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qom v4 0/2] Arrayify QOM properties.


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH qom v4 0/2] Arrayify QOM properties.
Date: Fri, 22 Aug 2014 16:24:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0

Am 20.08.2014 08:55, schrieb Peter Crosthwaite:
> Resending with addition of this cover letter (for those who rely
> on patches tool for series review).
> 
> Changed since v3:
> Added cover letter.
> 
> Regards,
> Peter
> 
> 
> 
> Peter Crosthwaite (2):
>   qom: object_property_add: Add automatic arrayification
>   memory: remove object_property_add_child_array
> 
>  memory.c     | 30 +++++-------------------------
>  qom/object.c | 21 +++++++++++++++++++++
>  2 files changed, 26 insertions(+), 25 deletions(-)

I noticed that 1/2 is merely a code movement from 2/2, so my criticism
of the "calling convention" can be addressed later. Applied, thanks.

https://github.com/afaerber/qemu-cpu/commits/qom-next

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]