[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avoid to break compiling |
Date: |
Fri, 22 Aug 2014 10:54:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 22/08/2014 04:01, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> variables lun and tag had been eliminated, break compiling
> when enable debug switch. Meanwhile traces provide the same
> information with this DPRINTF, so remove it.
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> v2:
> - as Paolo's suggestion, remove the superfluous DPRINTF.
> - change patch topic and commit message.
> ---
> hw/scsi/scsi-generic.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
> index 0b2ff90..0b352fc 100644
> --- a/hw/scsi/scsi-generic.c
> +++ b/hw/scsi/scsi-generic.c
> @@ -303,9 +303,6 @@ static int32_t scsi_send_command(SCSIRequest *req,
> uint8_t *cmd)
> SCSIDevice *s = r->req.dev;
> int ret;
>
> - DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
> - r->req.cmd.xfer, cmd[0]);
> -
> #ifdef DEBUG_SCSI
> {
> int i;
>
Applied, thanks.
Paolo