[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB opcode format |
Date: |
Thu, 21 Aug 2014 13:41:50 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote:
> @@ -679,9 +768,11 @@ gen_intermediate_code_internal(TRICORECPU *cpu, struct
> TranslationBlock *tb,
> num_insns++;
>
> if (tcg_ctx.gen_opc_ptr >= gen_opc_end) {
> + gen_goto_tb(&ctx, 0, ctx.next_pc);
> break;
> }
> if (singlestep) {
> + gen_goto_tb(&ctx, 0, ctx.next_pc);
> break;
> }
Do not use goto_tb under singlestep. That can make it very hard to debug
translator bugs. I've been considering checking for that at the tcg level,
except that almost all translators have this bug.
r~
- [Qemu-devel] [PATCH v5 04/15] target-tricore: Add initialization for translation and activate target, (continued)
- [Qemu-devel] [PATCH v5 04/15] target-tricore: Add initialization for translation and activate target, Bastian Koppelmann, 2014/08/13
- [Qemu-devel] [PATCH v5 05/15] target-tricore: Add masks and opcodes for decoding, Bastian Koppelmann, 2014/08/13
- [Qemu-devel] [PATCH v5 01/15] target-tricore: Add target stubs and qom-cpu, Bastian Koppelmann, 2014/08/13
- [Qemu-devel] [PATCH v5 02/15] target-tricore: Add board for systemmode, Bastian Koppelmann, 2014/08/13
- [Qemu-devel] [PATCH v5 15/15] target-tricore: Add instructions of SR opcode format, Bastian Koppelmann, 2014/08/13
- [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB opcode format, Bastian Koppelmann, 2014/08/13
- Re: [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB opcode format,
Richard Henderson <=
- [Qemu-devel] [PATCH v5 12/15] target-tricore: Add instructions of SBR opcode format, Bastian Koppelmann, 2014/08/13
- [Qemu-devel] [PATCH v5 09/15] target-tricore: Add instructions of SRRS and SLRO opcode format, Bastian Koppelmann, 2014/08/13
- [Qemu-devel] [PATCH v5 03/15] target-tricore: Add softmmu support, Bastian Koppelmann, 2014/08/13
- Re: [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation, Bastian Koppelmann, 2014/08/20
- Re: [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation, Andreas Färber, 2014/08/20