Re: [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object

[Paolo Bonzini]

Il 21/08/2014 05:02, Fam Zheng ha scritto:
> On Wed, 08/20 15:29, Paolo Bonzini wrote:
>> Il 20/08/2014 12:01, Fam Zheng ha scritto:
>>> +
>>> +qemuutil.o: CC_REL_FLAGS := -Wl,-r
>>
>> Why the target-specific rule?
>>
>>> +qemuutil.o: $(util-obj-y)
>>> +   $(call quiet-command,$(CC) -nostdlib $(CC_REL_FLAGS) -o $@ $^,"  LD -r  
>>> $(TARGET_DIR)$@")
>>>  
>>
>>
>> I think either you have
>>
>> LD_REL := $(CC) -nostdlib -Wl,-r
>>
>> (as opposed to "LD_REL := $(LD) -r" for example) or you do not need to
>> put -Wl,-r in a separate variable.
> 
> Because comma doesn't work in Makefile macro invocation, we need to wrap the
> flag in a variable. (Is there a way to escape it?)

Well, there's

  comma=,

and $(comma).  Or

  Wl=-Wl,

of course.  But neither is particularly nice.

> Your LD_REL looks cleaner though.

Okay, let's go with it then.

Paolo