[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an i
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function |
Date: |
Wed, 20 Aug 2014 15:20:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 20/08/2014 13:36, Michael S. Tsirkin ha scritto:
>
> For pci bridges, unless you set bus_name, bus name will
> match device itself. See this code:
>
> * If we don't specify the name, the bus will be addressed as
> * <id>.0, where id is the device id.
> * Since PCI Bridge devices have a single bus each, we don't need
> * the index:
> * let users address the bus using the device name.
> */
> if (!br->bus_name && dev->qdev.id && *dev->qdev.id) {
> br->bus_name = dev->qdev.id;
> }
Is libvirt using this rule? If not, I'd rather slash it since the
<id>.0 name is shared with all other buses and not PCI-bridge-specific.
Paolo
- [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Knut Omang, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Paolo Bonzini, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Knut Omang, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Michael S. Tsirkin, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Knut Omang, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Markus Armbruster, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Eric Blake, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Paolo Bonzini, 2014/08/21
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Markus Armbruster, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Michael S. Tsirkin, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Markus Armbruster, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Paolo Bonzini, 2014/08/20
- Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Markus Armbruster, 2014/08/20
Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function, Andreas Färber, 2014/08/20