[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 11/23] linux-user: Dereference Pointer Argument to
From: |
riku . voipio |
Subject: |
[Qemu-devel] [PULL v2 11/23] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call |
Date: |
Tue, 19 Aug 2014 11:32:46 +0300 |
From: Tom Musta <address@hidden>
When the ipc system call is used to wrap a semctl system call,
the ptr argument to ipc needs to be dereferenced prior to passing
it to the semctl handler. This is because the fourth argument to
semctl is a union and not a pointer to a union.
Signed-off-by: Tom Musta <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
---
linux-user/syscall.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 239e682..0113250 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -3140,9 +3140,15 @@ static abi_long do_ipc(unsigned int call, int first,
ret = get_errno(semget(first, second, third));
break;
- case IPCOP_semctl:
- ret = do_semctl(first, second, third, (union target_semun)(abi_ulong)
ptr);
+ case IPCOP_semctl: {
+ /* The semun argument to semctl is passed by value, so dereference the
+ * ptr argument. */
+ abi_ulong atptr;
+ get_user_ual(atptr, (abi_ulong)ptr);
+ ret = do_semctl(first, second, third,
+ (union target_semun)(abi_ulong) atptr);
break;
+ }
case IPCOP_msgget:
ret = get_errno(msgget(first, second));
--
2.0.1
- [Qemu-devel] [PULL v2 00/23] linux-user updates, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 05/23] linux-user: fix readlink handling with magic exe symlink, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 03/23] linux-user: Fix syscall instruction usermode emulation on X86_64, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 07/23] linux-user: support ioprio_{get, set} syscalls, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 08/23] linux-user: support {name_to, open_by}_handle_at syscalls, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 11/23] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call,
riku . voipio <=
- [Qemu-devel] [PULL v2 09/23] linux-user: add setns and unshare, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 02/23] linux-user: redirect openat calls, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 12/23] linux-user: Properly Handle semun Structure In Cross-Endian Situations, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 06/23] linux-user: support timerfd_{create, gettime, settime} syscalls, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 10/23] linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 04/23] linux-user: Fix conversion of sigevent argument to timer_create, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 01/23] linux-user: /proc/self/maps content, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 16/23] linux-user: Handle NULL sched_param argument to sched_*, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 13/23] linux-user: Make ipc syscall's third argument an abi_long, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 17/23] linux-user: Detect fault in sched_rr_get_interval, riku . voipio, 2014/08/19