Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

[Eric Blake]

On 08/15/2014 03:01 PM, Michael Roth wrote:

>>> I tried to compile on Fedora 20, but had to backport this to get it to work:
>>>
>>> Luiz Capitulino
>>> a49db98d fpu: softfloat: drop INLINE macro
>>>
>>
>> ping
> 
> Hmm, unfortunately I didn't see this until after 2.0.1 was tagged/pushed. My
> understanding however was that the build issues you were seeing were the 
> result
> of a dirty build directory. Can you confirm whether or not the build issue
> is present in v2.0.1 (now tagged in origin)? If a build fix is still required
> I can push a minor v2.0.2 update monday and skip v2.0.1 for the
> announcement/tarball.

Using Fedora 20, I did a fresh clone to v2.0.1, followed by:

 ./configure --enable-kvm --enable-system --disable-user \
   --target-list=x86_64-softmmu --enable-debug

and make failed:

In file included from /usr/include/spice-server/spice.h:25:0,
                 from /home/eblake/qemu-tmp/include/ui/qemu-spice.h:25,
                 from qemu-char.c:84:
/usr/include/spice-1/spice/macros.h:105:0: error: "INLINE" redefined
[-Werror]
 #define INLINE inline
 ^

Bummer. It's unrelated to a dirty build directory.  I don't know how
many others will be impacted, to know if it warrants an immediate 2.0.2
(if it's just me hitting it, I don't mind calling 2.0.1 good; and distro
packagers can do the trivial backport that I did).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature