[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/20] ivshmem: check the value returned by fstat()
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 20/20] ivshmem: check the value returned by fstat() |
Date: |
Fri, 15 Aug 2014 19:15:11 +0400 |
From: zhanghailiang <address@hidden>
The function fstat() may fail, so check its return value.
Acked-by: Levente Kurusa <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/misc/ivshmem.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 768e528..2be4b86 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -324,7 +324,11 @@ static int check_shm_size(IVShmemState *s, int fd) {
struct stat buf;
- fstat(fd, &buf);
+ if (fstat(fd, &buf) < 0) {
+ fprintf(stderr, "ivshmem: exiting: fstat on fd %d failed: %s\n",
+ fd, strerror(errno));
+ return -1;
+ }
if (s->ivshmem_size > buf.st_size) {
fprintf(stderr,
--
1.7.10.4
- [Qemu-devel] [PULL 00/20] Trivial patches for 2014-08-15, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 02/20] memory: Update obsolete comment about AddrRange field type, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 08/20] audio: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 01/20] apic: Fix reported DFR content, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 07/20] usb: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 06/20] CODING_STYLE: Section about conditional statement, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 13/20] vmxnet3: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 19/20] l2cap: fix access to freed memory, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 14/20] qemu-options.hx: fix typo about l2tpv3, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 16/20] ssi: xilinx_spi: Initialise CS GPIOs as NULL, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 20/20] ivshmem: check the value returned by fstat(),
Michael Tokarev <=
- [Qemu-devel] [PULL 12/20] vl: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 11/20] spice: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 04/20] pci-host: update obsolete reference about piix_pci.c, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 09/20] isa-bus: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 03/20] qemu-options.hx: fix a typo of chardev, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 05/20] pci-host: update uncorresponding description, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 10/20] don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 18/20] intc: i8259: Convert Array allocation to g_new0, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 17/20] ppc: convert g_new(qemu_irq usages to g_new0, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 15/20] vl: free err, Michael Tokarev, 2014/08/15