[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] cmd646: synchronise UDMA interrupt status w
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] cmd646: synchronise UDMA interrupt status with DMA interrupt status |
Date: |
Mon, 11 Aug 2014 16:12:23 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Aug 08, 2014 at 05:23:36PM +0100, Mark Cave-Ayland wrote:
> @@ -322,6 +342,10 @@ static int pci_cmd646_ide_initfn(PCIDevice *dev)
> }
>
> /* Set write-to-clear interrupt bits */
> + dev->wmask[CFR] = 0x0;
> + dev->w1cmask[CFR] = CFR_INTR_CH0;
> + dev->wmask[ARTTIM23] = 0x0;
> + dev->w1cmask[ARTTIM23] = ARTTIM23_INTR_CH1;
> dev->wmask[MRDMODE] = 0x0;
> dev->w1cmask[MRDMODE] = MRDMODE_INTR_CH0 | MRDMODE_INTR_CH1;
It is not clear to me why the mask for MRDMODE has both Channel 0 and 1
but the ARTTIM23 and CFR masks only have one channel each.
Please post a link to the datasheet.
pgpwfemcIS7dk.pgp
Description: PGP signature