Re: [Qemu-devel] [PATCH 2/2] ivshmem: convert option 'use64' to a bit instead of integer

[Levente Kurusa]

> On Mon, Aug 04, 2014 at 05:06:21PM +0200, Levente Kurusa wrote:
> > It was expecting an integer, however the sole usecase of it just
> > checked whether it was assigned to or not. Hence, remove integerness,
> > and add a new bitfield instead.
> > 
> > Signed-off-by: Levente Kurusa <address@hidden>
> 
> This might break some existing scripts.
> If you want to address this, add a new type that
> can accept both integer and bool.

Yea, makes sense.

I don't really know whether adding a new type is worth the effort;
let's just drop this patch and keep the interface as it is, since it
makes no harm.

Should I resend the first patch as a separate patch or can it be
applied as it is?

Oh, and are we taking the ivshmem command line as set in stone?
I'm asking because I don't really see the point in that, given that
ivshmem is still experimental and broken in many cases.

Thanks,
Levente Kurusa