[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] block: Catch !bs->drv in bdrv_check()

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 3/3] block: Catch !bs->drv in bdrv_check()
Date: Fri, 8 Aug 2014 11:15:28 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 07.08.2014 um 22:47 hat Max Reitz geschrieben:
> qemu-img check calls bdrv_check() twice if the first run repaired some
> inconsistencies. If the first run however again triggered corruption
> prevention (on qcow2) due to very bad inconsistencies, bs->drv may be
> NULL afterwards. Thus, bdrv_check() should check whether bs->drv is set.
> Signed-off-by: Max Reitz <address@hidden>

I suppose there was a real case of this happening? I think bdrv_check()
triggering corruption prevention is a rather bad sign. The most
important point for image repair should be that it doesn't make the
situation any worse. Smells like a follow-up patch to the qcow2 code.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]