[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions
From: |
arei.gonglei |
Subject: |
[Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions |
Date: |
Mon, 4 Aug 2014 17:19:44 +0800 |
From: Gonglei <address@hidden>
$WHATEVER: don't use 'Yoda conditions'
'Yoda conditions' are not part of idiomatic QEMU coding
style, so rewrite them in the more usual order.
v4:
- trivial typo for patch 1/8 suggested by Eric, thanks.
v3:
- rewrite CODINT_STYLE file suggested by Eric, thanks.
- rename the patch serials.
- imitate nearby code about using '!value' or 'value == NULL' at
every patch suggested by Markus.
v2:
- add more specific commit messages suggested by PMM, thanks.
- introduce section of conditional statement to CODING_STYLE.
Gonglei (8):
CODING_STYLE: Section about conditional statement
usb: don't use 'Yoda conditions'
audio: don't use 'Yoda conditions'
isa-bus: don't use 'Yoda conditions'
don't use 'Yoda conditions'
spice: don't use 'Yoda conditions'
vl: don't use 'Yoda conditions'
vmxnet3: don't use 'Yoda conditions'
CODING_STYLE | 14 ++++++++++++++
hw/audio/gus.c | 2 +-
hw/audio/hda-codec.c | 3 ++-
hw/audio/sb16.c | 6 +++---
hw/isa/isa-bus.c | 2 +-
hw/net/vmxnet3.c | 16 ++++++++--------
hw/usb/dev-audio.c | 2 +-
hw/usb/dev-mtp.c | 4 ++--
hw/usb/hcd-ehci.c | 2 +-
qdev-monitor.c | 2 +-
qemu-char.c | 2 +-
ui/spice-core.c | 4 ++--
util/qemu-sockets.c | 2 +-
vl.c | 5 +++--
14 files changed, 41 insertions(+), 25 deletions(-)
--
1.7.12.4
- [Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions,
arei.gonglei <=
- [Qemu-devel] [PATCH v4 7/8] vl: don't use 'Yoda conditions', arei.gonglei, 2014/08/04
- [Qemu-devel] [PATCH v4 8/8] vmxnet3: don't use 'Yoda conditions', arei.gonglei, 2014/08/04
- [Qemu-devel] [PATCH v4 3/8] audio: don't use 'Yoda conditions', arei.gonglei, 2014/08/04
- [Qemu-devel] [PATCH v4 5/8] don't use 'Yoda conditions', arei.gonglei, 2014/08/04
- [Qemu-devel] [PATCH v4 2/8] usb: don't use 'Yoda conditions', arei.gonglei, 2014/08/04
- [Qemu-devel] [PATCH v4 6/8] spice: don't use 'Yoda conditions', arei.gonglei, 2014/08/04
- [Qemu-devel] [PATCH v4 4/8] isa-bus: don't use 'Yoda conditions', arei.gonglei, 2014/08/04
- [Qemu-devel] [PATCH v4 1/8] CODING_STYLE: Section about conditional statement, arei.gonglei, 2014/08/04
- Re: [Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions, Eric Blake, 2014/08/05