[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] nic: do not destroy memory regions in clean
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 5/9] nic: do not destroy memory regions in cleanup functions |
Date: |
Thu, 31 Jul 2014 10:46:31 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jul 30, 2014 at 12:27:08PM +0200, Paolo Bonzini wrote:
> The memory regions should be destroyed in the unrealize function;
> since these NICs are not even qdev-ified, they cannot be unplugged
> and they do not have to do anything to destroy their memory regions.
>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/net/dp8393x.c | 3 ---
> hw/net/mcf_fec.c | 3 ---
> 2 files changed, 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpzqGl9aK7cU.pgp
Description: PGP signature
- [Qemu-devel] [PATCH for-2.2 0/9] memory: remove memory_region_destroy, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 1/9] qom: object: delete properties before calling instance_finalize, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 4/9] vga: do not dynamically allocate chain4_alias, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 2/9] qom: object: move unparenting to the child property's release callback, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 3/9] sysbus: remove unused function sysbus_del_io, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 5/9] nic: do not destroy memory regions in cleanup functions, Paolo Bonzini, 2014/07/30
- Re: [Qemu-devel] [PATCH 5/9] nic: do not destroy memory regions in cleanup functions,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 6/9] ioport: split deletion and destruction, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 7/9] memory: convert memory_region_destroy to object_unparent, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 8/9] memory: remove memory_region_destroy, Paolo Bonzini, 2014/07/30
- [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback, Paolo Bonzini, 2014/07/30