Re: [Qemu-devel] [PATCH v3 2/7] bootindex: add del_boot_device_path function

[Gonglei (Arei)]

Hi,

> > Introduce a del_boot_device_path() cleanup fw_cfg content
> > when hot-unplugging devcie refer to bootindex.
> 
> s/devcie/device/
> 
> sounds odd; maybe:
> 
> Introduce del_boot_device_path() to clean up fw_cfg content when
> hot-unplugging a device that refers to a bootindex.
> 
OK. Thanks, Eric.

> > +
> > +    QTAILQ_FOREACH(i, &fw_boot_order, link) {
> > +        if (i->dev->id && dev->id && !strcmp(i->dev->id, dev->id)) {
> > +            /* remove all entries of the assigend dev */
> 
> s/assigend/assigned/
> 
OK.

> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

Best regards,
-Gonglei