qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/15] virtio: decrease size of VirtQueueElement


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 08/15] virtio: decrease size of VirtQueueElement
Date: Wed, 30 Jul 2014 16:50:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 30/07/2014 16:40, Michael S. Tsirkin ha scritto:
> As long as you relying on this, why not allocate in_sg/out_sg
> separately?

Because allocations can be expensive.

> In any case, a bunch of code needs to be audited to make sure
> no one assumes we can always stick VIRTQUEUE_MAX_SIZE there.
> 
> But what really worries me is this is an optimization patch
> without any numbers accompanying it.

I agree.

> I would say split this out from your virtio blk work,
> work on this separately.

This, too.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]