Re: [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vmstate testing process

[Sanidhya Kashyap]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> +# +# Since 2.2 +## +{ 'command' : 'test-vmstates-set-period', +
>> 'data'    : { 'period': 'int' } }
> 
> Is it possible that we might add other tunables in the future?  If
> so, this command is not very scalable (we would be adding one
> command per new tunable).  On the other hand, adding complexity to
> achieve a generic setter is not worth it if we only expect one
> tunable.
> 


I was thinking of making it scalable as you already pointed out in the
previous patch but it does not look like there is something going to
be added in the future. So, that's why I am stuck with a single
parameter change.

>> +void qmp_test_vmstates_set_period(int64_t period, Error **errp) 
>> +{ +    VMStateLogState *v = vmstate_current_state(); +    if
>> (period < TEST_VMSTATE_MIN_INTERVAL_MS || +        period >
>> TEST_VMSTATE_MAX_INTERVAL_MS) { +        error_setg(errp, "sleep
>> interval (period) value must be " +                   "in the
>> defined range [%d, %d](ms)\n", +
>> TEST_VMSTATE_MIN_INTERVAL_MS, TEST_VMSTATE_MAX_INTERVAL_MS); +
>> return; +    } +    v->period = period; +}
> 
> This looks like it takes effect whether or not a vmstate test is 
> underway.  Does this impact the default of the next vmstate test
> to

Yes

> start, in the case where that command doesn't supply a value for
> period but relies on the default?

No, it does not.


- -- 
- -----

Sanidhya Kashyap
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJT1+JFAAoJEFt9RLmoahln4qcIAJngjCqqQtDCjuAPnGxQnamM
Y7IUNe9Z0fGIYp88tHZN32cpaxbMkT+BEL7QeJDynrXcaH+SVIwOepPQNYqVdzzh
q4ldQW/D5VxC/xKXtenHZbAx3+Iat00dHHutq8y4ezR1DH9N1GfTHyKCewP6WP96
dy4RAJvKgItpRfu3FuGoLRxqWbAre1NrwydQZtiv3C1t14sM/Ua2j7Syp5vhhCtM
GtQrhKt2I1Hr0fGupbarLWRNKXyCBi7XgDG6+NvJNP6ECAh5GeVmQ7e9L891tL3b
wi9a4GNL45sVLa3tLBG81aGIn1XJOX6UEdRJIqWyIKCkC/LS417waitb1oWWfYw=
=9HHf
-----END PGP SIGNATURE-----