Re: [Qemu-devel] [PATCH] hw/arm/virt: fix pl031 addr typo

[Peter Maydell]

On 29 July 2014 17:06, Andrew Jones <address@hidden> wrote:
> On Tue, Jul 29, 2014 at 04:58:44PM +0100, Peter Maydell wrote:
>> On 29 July 2014 16:44, Andrew Jones <address@hidden> wrote:
>> > pl031's base address should be 0x9001000, 0x90010000. While in there
>                                              ^ meant to type 'not' here,
> but guess that was obvious
>> > also add some spacing and zeros to make it easier to read the map.
>
> I can send two separate patches for the fix and the formatting, but
> you'd still have to check the formatting patch closely to make sure
> nothing else changed...

Yes, or you could just not mess with the formatting at all.

>> > Signed-off-by: Andrew Jones <address@hidden>
>> > -    [VIRT_RTC] = { 0x90010000, 0x1000 },
>> > +    [VIRT_RTC] =        { 0x09001000, 0x00001000 },
>>
>> ...and assuming from the commit message that this is the
>> only actual change, the alignment to 64K is deliberate,
>> for the benefit of guests with 64K pages.
>
> 0K, so it needs to be 0x09010000, which is still not what it is.
> As it is right now it's sitting in RAM, when configuring a guest
> to have greater than 1G.

Ah, I see now. That is a bad bug and it's really
unfortunate that you've missed the boat for 2.1
by about 24 hours :-(

thanks
-- PMM