Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

[Gonglei (Arei)]

> -----Original Message-----
> From: Gerd Hoffmann [mailto:address@hidden
> Sent: Monday, July 28, 2014 4:31 PM
> Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function
> 
>   Hi,
> 
> > > ... because you can just copy the suffix from the old entry here,
> > > instead of expecting the caller pass it in.
> > >
> > Okay, agreed.
> >
> > But we should also think about the situation which a device don't have
> > old entry in global fw_boot_order list.
> 
> Throw an error?
> 
No. I should firstly use the suffix which the caller pass in IMHO,
just like V3 I have posted, Thanks.

> I think it is ok to allow only *changing* the bootindex.
> 
Yes, that's no problem.

Best regards,
-Gonglei