Re: [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server

[Daniel P. Berrange]

On Mon, Jul 21, 2014 at 08:21:21AM -0600, Eric Blake wrote:
> On 07/20/2014 03:38 AM, David Marchand wrote:
> > When using ivshmem devices, notifications between guests can be sent as
> > interrupts using a ivshmem-server (typical use described in documentation).
> > The client is provided as a debug tool.
> > 
> > Signed-off-by: Olivier Matz <address@hidden>
> > Signed-off-by: David Marchand <address@hidden>
> > ---
> >  contrib/ivshmem-client/Makefile         |   26 ++
> 
> > +++ b/contrib/ivshmem-client/Makefile
> > @@ -0,0 +1,26 @@
> > +# Copyright 2014 6WIND S.A.
> > +# All rights reserved
> 
> This file has no other license, and is therefore incompatible with
> GPLv2.  You'll need to resubmit under an appropriately open license.
> 
> > +++ b/contrib/ivshmem-client/ivshmem-client.h
> > @@ -0,0 +1,238 @@
> > +/*
> > + * Copyright(c) 2014 6WIND S.A.
> > + * All rights reserved.
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2.  See
> > + * the COPYING file in the top-level directory.
> 
> I'm not a lawyer, but to me, this license is self-contradictory.  You
> can't have "All rights reserved" and still be GPL, because the point of
> the GPL is that you are NOT reserving all rights, but explicitly
> granting your user various rights (on condition that they likewise grant
> those rights to others).  But you're not the only file in the qemu code
> base with this questionable mix.

In any case adding the term 'All rights reserved' is said to be redundant
obsolete these days

  https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|