[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent |
Date: |
Fri, 18 Jul 2014 15:31:40 +0200 |
From: Andreas Färber <address@hidden>
The current implementation depends on a configure-time generated list of
block modules. When any of them is absent, module_load() emits a warning.
This is suboptimal because extracting code to modules was mainly done to
allow separate packaging of modules with intrusive dependencies. Absence
of optional packages then leads to absence of modules and an error
message, which users may recognize as new and report as error.
Cc: Paolo Bonzini <address@hidden>
Cc: Michael Tokarev <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
util/module.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/util/module.c b/util/module.c
index 9fd3030..4bd4a94 100644
--- a/util/module.c
+++ b/util/module.c
@@ -209,9 +209,6 @@ static void module_load(module_init_type type)
break;
}
}
- if (ret == -ENOENT) {
- fprintf(stderr, "Can't find module: %s\n", *mp);
- }
}
for (i = 0; i < ARRAY_SIZE(dirs); i++) {
--
1.9.3
- [Qemu-devel] [PULL v2 for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18, Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled., Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 3/6] module: Simplify module_load(), Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent,
Paolo Bonzini <=
- [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation", Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700, Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward", Paolo Bonzini, 2014/07/18
- Re: [Qemu-devel] [PULL v2 for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18, Peter Maydell, 2014/07/18