qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: Give error message if hos


From: Peter Maydell
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: Give error message if hostfwd_add/remove for unrecognized vlan/stack
Date: Fri, 18 Jul 2014 08:13:21 +0100

On 18 July 2014 06:22, Michael Tokarev <address@hidden> wrote:
> 08.07.2014 15:39, Peter Maydell wrote:
>> On 26 June 2014 13:35, Peter Maydell <address@hidden> wrote:
>>> On 16 June 2014 16:47, Peter Maydell <address@hidden> wrote:
>>>> If the user specified a (vlan ID, slirp stack name) tuple in a monitor
>>>> hostfwd_add/remove command and we can't find it, give the user an
>>>> error message rather than silently doing nothing.
>>>>
>>>> This brings this error case in slirp_lookup() into line with the
>>>> other two.

> Peter, I returned from vacation yesterday, so I weren't able to process 
> -trivial
> queue before, and due to the time constraints we have before 2.1, I'm not sure
> it is a good idea to make a pull request for the -trivial tree.  I'll pick 
> this
> one up but it might be better to apply this directly.

At this point and given the slirp code has been like this for a long
time, I think it's probably best to let it go til 2.2.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]