[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] linux-user: make binfmt flag O require P
From: |
Joakim Tjernlund |
Subject: |
Re: [Qemu-devel] [PATCH v2] linux-user: make binfmt flag O require P |
Date: |
Tue, 15 Jul 2014 15:45:08 +0200 |
Riku Voipio <address@hidden> wrote on 2014/07/15 15:20:35:
>
> On Mon, Jul 14, 2014 at 11:37:02PM +0200, Joakim Tjernlund wrote:
> > Joakim Tjernlund/Transmode wrote on 2014/07/14 23:04:51:
> > > > Why do we need to modify argv[] here when we are building a
> > > > target_argv[] further down anyway?
> >
> > > Because parse_opts() will not do it for me and I cannot figure out
how
> > to modify
> > > parse_opts() whithout breaking it.
>
> > I took another look and now I came up with:
>
> Looks good for me too, but I think a little too disruptive for 2.1 which
> is now in rc's ?
Was just about to send you v2 :)
Considering binfmt does not work for qemu-user without external hacks you
may want to reconsider.
You would have to test it a bit more though I guess, your call.