Re: [Qemu-devel] [PATCH 01/46] qemu_ram_foreach_block: pass up error value, and down the ramblock name

[Eric Blake]

On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> check the return value of the function it calls and error if it's none-0
> Fixup qemu_rdma_init_one_block that is the only current caller,
>   and __qemu_rdma_add_block the only function it calls using it.

As long as you are at it, is it worth renaming the use of __qemu prefix
in a function name?  That namespace is reserved for the compiler/libc,
and we shouldn't be stomping on it.  Probably best as a separate patch.

> 
> Pass the name of the ramblock to the function; helps in debugging.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  exec.c                    | 10 ++++++++--
>  include/exec/cpu-common.h |  4 ++--
>  migration-rdma.c          |  4 ++--
>  3 files changed, 12 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature