qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request l


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request length
Date: Sat, 05 Jul 2014 22:14:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 04.07.2014 17:55, Kevin Wolf wrote:
At least raw-posix relies on this because it can allocate bounce buffers
based on the request length, but access it using all of the qiov entries
later.

Signed-off-by: Kevin Wolf <address@hidden>
---
  block.c           |  2 ++
  block/raw-posix.c | 15 +++++++++++----
  2 files changed, 13 insertions(+), 4 deletions(-)

Somehow I'm not sure whether I want to give my R-b to this, in case one of these assertions should fail. ;-)

But they look correct (considering QIO vectors now have to be just as long as the request), so:

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]