[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and
From: |
Ming Lei |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue |
Date: |
Fri, 4 Jul 2014 17:21:24 +0800 |
On Fri, Jul 4, 2014 at 5:18 PM, Ming Lei <address@hidden> wrote:
>>
>> This leaks requests when ret < len. I think the loop below should be
>> used in that case to fail unsubmitted requests with -EIO.
>
> I thought about the problem before, but looks it may not return 'ret'
> which is less than
> len, follows the man io_submit():
>
> The function returns immediately after having enqueued all
> the requests. On suc‐
> cess, io_submit returns the number of iocbs submitted
> successfully. Otherwise,
> -error is return, where error is one of the Exxx values
> defined in the Errors sec‐
> tion.
>
> The above description looks a bit confusing, and I will check linux
> fs/aio.c to see
> if there is the case.
Ah, fs/aio.c do have the case, will fix in v6.
Thanks,
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, (continued)
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Ming Lei, 2014/07/03
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Paolo Bonzini, 2014/07/03
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Ming Lei, 2014/07/03
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Paolo Bonzini, 2014/07/03
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Ming Lei, 2014/07/03
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Kevin Wolf, 2014/07/03
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Ming Lei, 2014/07/03
- Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Kevin Wolf, 2014/07/03
Re: [Qemu-devel] [PATCH v4 2/3] linux-aio: implement io plug, unplug and flush io queue, Stefan Hajnoczi, 2014/07/03
[Qemu-devel] [PATCH v4 3/3] dataplane: submit I/O as a batch, Ming Lei, 2014/07/02
Re: [Qemu-devel] [PATCH v4 3/3] dataplane: submit I/O as a batch, Stefan Hajnoczi, 2014/07/03
Re: [Qemu-devel] [PATCH v4 3/3] dataplane: submit I/O as a batch, Stefan Hajnoczi, 2014/07/03
Re: [Qemu-devel] [PATCH v4 0/3] linux-aio: introduce submit I/O as a batch, Kevin Wolf, 2014/07/03
Re: [Qemu-devel] [PATCH v4 0/3] linux-aio: introduce submit I/O as a batch, Stefan Hajnoczi, 2014/07/03